When a user has more fines than maxoutstanding holds are no longer possible. The fine amount displayed should be formatted according to the CurrencyFormat system preference.
Created attachment 83832 [details] [review] Bug 22111: Format price on place holds place when maxoutstanding is reached Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting
Created attachment 83837 [details] [review] Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting
I believe these changes have already been made, this is the message I got when I tried to test. Setting to resolved $ git bz apply 22111 Bug 22111 - Correctly format fines when placing holds (maxoutstanding warning) 83832 - Bug 22111: Format price on place holds place when maxoutstanding is reached 83837 - Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22111: Format price on place holds place when maxoutstanding is reached Applying: Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Falling back to patching base and 3-way merge... No changes -- Patch already applied.
Hi Ethan, thx for testing! This was my fault. When I attached a second version of the patch with a changed commit message, I forgot to obsolete the first one. So when you tried to test it applied both and the second caused the warning as the change was the same in both. Could you please try again?
Created attachment 83987 [details] [review] Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 84228 [details] [review] Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com>
Created attachment 84269 [details] [review] Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
Pushed to 17.11.x for 17.11.15