There is an error when document status is shown. When the text information is "Item is normally not for loan", the text in brackets is always the authorized value even if there is a description for that.
Created attachment 83986 [details] [review] Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number.
Hi Pierre-Marc, We went through your steps but we didn't see any number under the column "Information" We saw "! Item not for loan" message there. Thanks. Devinim Koha Team
Created attachment 85013 [details] [review] Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This worked for me... Signing off.
Created attachment 85027 [details] [review] Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85028 [details] [review] Bug 22130: (follow-up) Show not for loan authorised values in batch checkout TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. 11) Try it with both: AllowNotForLoanOverride on and off Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Confused by the status of this one.. accidental set back to NSO rather than PQA perhaps?
Created attachment 85169 [details] [review] Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 85170 [details] [review] Bug 22130: (follow-up) Show not for loan authorised values in batch checkout TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. 11) Try it with both: AllowNotForLoanOverride on and off Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Martin Renvoize from comment #7) > Confused by the status of this one.. accidental set back to NSO rather than > PQA perhaps? True, sorry. Passed QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
backported to 18.05.x for 18.05.11