Go to a patron account page Click more -> Set permissions At the moment, if you select Superlibrarian, it is the same as selecting all. However, you can't then unselect one permission because the checkboxes are disabled. It is very slow and tedious to have to select every other checkbox one by one. There should be a way to disable the checkboxes when I want to unselect one or some permissions.
I think it is on purpose - superlibrarian means all, but it's actually more than 'all'. Superlibrarians can do more than some of the permissions, especially when it comes to Independentbranches. So there would be conflicts if you could have superlibrarian without some of the other permissions.
This conversation has nudged me to rebase my patch for Bug 11375 which redesigns the patron permission interface. I think that even with my redesign this is still an issue. I wonder if it could be solved by adding "check all" and "check none" controls where "check all" would automatically de-select the superlibrarian flag?
(In reply to Owen Leonard from comment #2) > > I think that even with my redesign this is still an issue. I wonder if it > could be solved by adding "check all" and "check none" controls where "check > all" would automatically de-select the superlibrarian flag? This is exactly what I had in mind. (In reply to Katrin Fischer from comment #1) > I think it is on purpose - superlibrarian means all, but it's actually more > than 'all'. Superlibrarians can do more than some of the permissions, > especially when it comes to Independentbranches. So there would be conflicts > if you could have superlibrarian without some of the other permissions. I meant that if you unselected any checkbox, the superlibrarian box would also be unselected.
Thx for commenting, I agree!
Created attachment 84170 [details] [review] Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected
This works well, but the superlibrarian checkbox shouldn't be checked when you click "Select all." If you check all, including the superlibrarian checkbox, and save, you'll get an error when you return to the permissions page: "Inconsistency detected! The superlibrarian privilege is mutually exclusive of other privileges, as it includes them all. This patron's privileges will now be reset to include only superlibrarian."
Created attachment 115490 [details] [review] Bug 22150: (follow-up) ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked
Created attachment 115530 [details] [review] Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard
Created attachment 115531 [details] [review] Bug 22150: ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked
The original patch no longer applied for me, so I rebased it and reattached both patches. I think this work well now, and have only one question that keeps me from signing off: Should the "Select all" action expand all the hidden permissions? I'm wondering if we should make it clear to the user that they are selecting a lot of things.
I think as there are so many it might make it less readable to expand all. I like the behaviour now. Signing off - Owen, if you ant to sign off too, we can count mine for QA :)
Created attachment 115594 [details] [review] Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115595 [details] [review] Bug 22150: ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115610 [details] [review] Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 115611 [details] [review] Bug 22150: Ability to select or unselect all member flags To test: 1) Find a patron 2) Click More -> Set permissions 3) Click 'Clear all', confirm all checkboxes get cleared and disabled 4) Click 'Select all', confirm all checkboxes get selected 5) Unselect one checkbox (not superlibrarian), and confirm that the superlibrarian checkbox also gets unselected 6) Confirm that saving still works as expected Edit: Rebased by Owen Leonard Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 115612 [details] [review] Bug 22150: ensuring superlibrarian flag not checked when select all Test plan: 1. Go to a patron account page 2. Click more, set permissions 3. If you select Superlibrarian, you can't unselect on box. 4. Apply first patch by Jasmine Amohia 5. Follow steps for that patch 6. Apply patch 7. Go through steps 1-4 from Jasmine Amohia, but now notice how when you click "Select all" the Superlibrarian checkbox is not checked Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 115691 [details] [review] Bug 22150: (follow-up) ensuring superlibrarian flag not checked when select all Use #flag-0 to select the superlibrarian checkbox
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x