When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. To reproduce: 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go in Advanced search 2.5) If necessary, click on 'More options' 3) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 4) Click on 'Search' 5) In the breadcrumbs, it says 'Search with limit(s): 'l-format:fk'' fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille The codes for marc21 can be found here: http://www.loc.gov/marc/bibliographic/bd007f.html Thank you!
Created attachment 87403 [details] [review] Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with tb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found
Hi, with ES I get: No results match your search with limit(s): 'ff7-01-02:tc or l-format:fb'. After full reindex. With Zebra I get just one result for search: for braile (tc) or large print (tb). Never both for brail. Same results in OPAC and staff client. Maybe I missed something. Some extra steps in test plan?
Hi Michal, I think with Elasticsearch that is another problem. Did you try if the other limits work with Elasticsearch as expected? The problem with the search lies in my test plan, I typoed with the codes. Braile is: tc or fb (not tb). I will upload a patch with an updated test plan.
Created attachment 87945 [details] [review] Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found
Thx for testing!
Created attachment 87946 [details] [review] Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar <black23@gmail.com>
ES problem reportetd as bug 22704.
Created attachment 87969 [details] [review] Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
backported to 18.05.x for 18.05.13