There are some markup and content corrections to be made to the Mana KB administration template.
Created attachment 84338 [details] [review] Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good.
*** Bug 22202 has been marked as a duplicate of this bug. ***
Created attachment 84352 [details] [review] Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good.
Created attachment 84357 [details] [review] Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable Also changed: Some language revisions to the Mana dialogs on the Administration home page. To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good.
Created attachment 84451 [details] [review] Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable Also changed: Some language revisions to the Mana dialogs on the Administration home page. To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good.
Created attachment 84452 [details] [review] Bug 22196: (QA follow-up) Fix some typo Fixes the typo on the admin main page.
I really like the clean-up, but from the discussion on the main bug I understood that the token is an optional feature and you would still be allowed to search for subscriptions/reports without it (what about commenting/rating?). If that's the case it would be nice to make this more clear in the documentation of the feature.
Created attachment 84503 [details] [review] Bug 22196: Clean up Mana KB administration template This patch makes language changes to the Mana KB administration template, and corresponding language changes to the Web Services preference file. Some markup errors have been fixed: - Correct title and breadcrumbs, copied and pasted from another template - Add ids to form fields to match their label "for" attributes - Make <input>s self-closing - Correct class names on alert dialogs - Wrap text in JavaScript with _() to make it translatable Also changed: Some language revisions to the Mana dialogs on the Administration home page. To test, apply the patch and go to Administration -> Share content with Mana KB. Test the process for enabling and configuring Mana KB. Check that forms work correctly and that the language of instructions and labels reads well. Go to Administration -> System preferences -> Web services, and confirm that the language changes to the Mana KB preference look good. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 84504 [details] [review] Bug 22196: (QA follow-up) Fix some typo Fixes the typo on the admin main page. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 84505 [details] [review] Bug 22196: (QA follow-up) Fix some more typo Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
*** Bug 22244 has been marked as a duplicate of this bug. ***
Awesome work all! Pushed to master for 19.05
An enhancement to a new feature for 19.05, not need to backport.