To recreate: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron
Created attachment 84370 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link
Created attachment 84425 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 84438 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 84447 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
Depends on Bug 18789 not in 17.11.x
Nick, why did you set hide_patron_infos_if_needed=1?
(In reply to Jonathan Druart from comment #9) > Nick, why did you set hide_patron_infos_if_needed=1? This was a copy/paste - reviewing how it works, this modal now respects the HidePatronName syspref - so while a change in behavior I think it should stand but am noting that effect here