The Mana KB registration form asks for first name and last name. I think a lot of libraries would prefer to sign up with a general account for the organisation (library@...). People can leave the library and more than one person might work with serials/reports. So I think tying the account to a person might not be the best way.
I agree! As long as the Mana registration is global for the whole Koha instance it makes sense to allow for a more general account. Right now I don't think it's clear to the user why the interface asks for their name... Is that information going to be displayed somewhere?
I am upping severity... I really feel using a name here is wrong. I'd like to at least get a comment? I am not sure what would be needed to change it.
Agreed, this is somewhat of a blocker for me too, I can't see our libraries adopting it as is.
Created attachment 89854 [details] [review] Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct
Created attachment 89923 [details] [review] Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com>
Hi Alex, patch works but if I follow ling filed Name, Last nname and e-mail are empty. I know it's on Mana server side ... Is it correct result? Thank you
(In reply to Michal Denar from comment #6) > Hi Alex, > patch works but if I follow ling filed Name, Last nname and e-mail are > empty. I know it's on Mana server side ... Is it correct result? > > Thank you I've also got some problems with the sign-up process. In my koha-conf.xml I have the mana test server, but when I register, the email I receive reads: https://ui.mana-kb.koha-community.org/registration?id=aa1JLPnpz6vBshtSpm2f6yr4sKKmJZ26 And clicking on it it tells me my token is too old or doesn't exist?
Moving to FQA. Needs feedback on the previous comments/questions.
(In reply to Michal Denar from comment #6) > Hi Alex, > patch works but if I follow ling filed Name, Last nname and e-mail are > empty. I know it's on Mana server side ... Is it correct result? > > Thank you Fixed on Mana server side
(In reply to Katrin Fischer from comment #7) > (In reply to Michal Denar from comment #6) > > Hi Alex, > > patch works but if I follow ling filed Name, Last nname and e-mail are > > empty. I know it's on Mana server side ... Is it correct result? > > > > Thank you > > I've also got some problems with the sign-up process. In my koha-conf.xml I > have the mana test server, but when I register, the email I receive reads: > https://ui.mana-kb.koha-community.org/ > registration?id=aa1JLPnpz6vBshtSpm2f6yr4sKKmJZ26 > > And clicking on it it tells me my token is too old or doesn't exist? Good catch Katrin! I fixed that in the configuration. Thx
Created attachment 90450 [details] [review] Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thank you Alex!
Mana pull request: https://git.biblibre.com/biblibre/koha-mana/pulls/3
Pull request: https://gitlab.com/koha-community/koha-mana/merge_requests/3
Created attachment 90592 [details] [review] Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 90593 [details] [review] Bug 22210: (QA follow-up) Tiny gramatical correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works for me and passes QA scripts. Passing QA
On second thoughts, I'm less sure about this.. do we need to version the Mana API as I believe the change on the mana server end is a breaking API change.. I know we're early days so nearly no-one would get caught by it right now, but we should probably get the procedures for such things in place now.
Just to clarify that.. if we pushed this as is now (and merged the request at the Mana end too).. then anyone running 19.05.00 Koha would need to use one Mana server whilst anyone running 19.05.01+ would need to point to another. This just highlights that we need to think differently during QA for this service.
We are early enough, let's push this into 19.11.01 (which means now we have translation break, but better now than later) and fix the Mana server at release day if possible. But I agree that in general we should make sure things stay backwards compatible or version properly.
OK, I'll push this as is but I really hope we get API versioning done during the .02 month as by .03 I think this will become a much bigger issue for end users.
Nice work! Pushed to master for 19.11.00
Mana test and prod are both up to date
Pushed to 19.05.x for 19.05.02
no backport for 18.11.x, missing dependencies