Created attachment 84514 [details] [review] Bug 22235: Make maintenance scripts use koha-sip instead of koha-*-sip This patch makes all maintenance scripts use **koha-sip** instead of the old **koha-*-sip** scripts. To test: - Run: $ perl misc4dev/cp_debian_files.pl $ sudo service koha-common stop => SUCCESS: No errors and the SIP-related sevices are stopped $ sudo service koha-common start => SUCCESS: No errors and the SIP-related services are started $ sudo service koha-common restart => SUCCESS: No erros and SIP-related services are running $ sudo koha-create --create-db test $ sudo koha-sip --enable test $ sudo koha-sip --start test $ sudo koha-disable test => SUCCESS: No errors, instance disabled, no SIP running for test - Sign off :-D
Created attachment 84515 [details] [review] Bug 22235: (follow-up) Make koha-remove stop SIP server if required
Getting this error at step 1: root@48864c0cb6e1:kohadevbox$ perl misc4dev/cp_debian_files.pl Cannnot open file No such file or directory at misc4dev/cp_debian_files.pl line 35.
(In reply to Kyle M Hall from comment #3) > Getting this error at step 1: > > root@48864c0cb6e1:kohadevbox$ perl misc4dev/cp_debian_files.pl > Cannnot open file No such file or directory at misc4dev/cp_debian_files.pl > line 35. The instructions were for kohadevbox, that's why they don't work :-/ In koha-testing-docker you need to run like this: root@b2cf8a1790c7:kohadevbox$ cd misc4dev root@b2cf8a1790c7:misc4dev(master)$ perl cp_debian_files.pl --koha_dir /kohadevbox/koha --instance kohadev --gitify_dir /kohadevbox/gitify Thanks for your interest!
Created attachment 84793 [details] [review] Bug 22235: Make maintenance scripts use koha-sip instead of koha-*-sip This patch makes all maintenance scripts use **koha-sip** instead of the old **koha-*-sip** scripts. To test: - Run: $ perl misc4dev/cp_debian_files.pl $ sudo service koha-common stop => SUCCESS: No errors and the SIP-related sevices are stopped $ sudo service koha-common start => SUCCESS: No errors and the SIP-related services are started $ sudo service koha-common restart => SUCCESS: No erros and SIP-related services are running $ sudo koha-create --create-db test $ sudo koha-sip --enable test $ sudo koha-sip --start test $ sudo koha-disable test => SUCCESS: No errors, instance disabled, no SIP running for test - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 84794 [details] [review] Bug 22235: (follow-up) Make koha-remove stop SIP server if required Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 84954 [details] [review] Bug 22235: Make maintenance scripts use koha-sip instead of koha-*-sip This patch makes all maintenance scripts use **koha-sip** instead of the old **koha-*-sip** scripts. To test: - Run: $ perl misc4dev/cp_debian_files.pl $ sudo service koha-common stop => SUCCESS: No errors and the SIP-related sevices are stopped $ sudo service koha-common start => SUCCESS: No errors and the SIP-related services are started $ sudo service koha-common restart => SUCCESS: No erros and SIP-related services are running $ sudo koha-create --create-db test $ sudo koha-sip --enable test $ sudo koha-sip --start test $ sudo koha-disable test => SUCCESS: No errors, instance disabled, no SIP running for test - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 84955 [details] [review] Bug 22235: (follow-up) Make koha-remove stop SIP server if required Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good job, Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
missing 18562, wont backport to 18.05.x