When a new subscription is created using data from Mana, a mana_id value is added to the subscription table. In Serials.pm ModSubscription was not modified to include mana_id, so subscription edits do not correctly link to Mana.
Created attachment 84533 [details] [review] Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully.
Created attachment 86028 [details] [review] Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
How can I find an existing pattern on Mana for testing?
(In reply to Katrin Fischer from comment #3) > How can I find an existing pattern on Mana for testing? Hi Katrin, you can find subscriptions using subscriptions mana search from main serial module page - it could be accessed from left menu.
Created attachment 86575 [details] [review] Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Awesome work all! Pushed to master for 19.05
Bug on enhancement not in 18.11.x series.