Bug 22247 - Koha::IssuingRule->get_effective_issuing_rule has no hard fallback
Summary: Koha::IssuingRule->get_effective_issuing_rule has no hard fallback
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-31 13:18 UTC by Martin Renvoize
Modified: 2019-11-01 20:45 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-01-31 13:18:35 UTC
We don't yet make full use of this Koha::IssuingRule in koha, however I have now found that the get_effective_... method within it behaves differently to the some of the C4 modules which query the same table..

In C4::Circulation there is a hard coded default should the default rule not be set (*, *, *) which claims a loan of 0 days.  This default either needs to be coded into get_effective_issuing_rule or a Koha::Exception thrown is such a rule is not found or something....
Comment 1 Magnus Enger 2019-09-10 07:50:11 UTC
A library in Sweden that upgraded to 19.05.x says that circ rules involving "all" patron categories and/or itemtypes stopped working after the upgrade. Only rules with specific itemtypes and patrone categories work. Could this be related to the problem described here?