Bug 22281 - Keydown event properties (keyCode and which) are both deprecated
Summary: Keydown event properties (keyCode and which) are both deprecated
Status: RESOLVED DUPLICATE of bug 36580
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-06 13:37 UTC by Marcel de Rooy
Modified: 2024-04-11 17:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2019-02-06 13:37:01 UTC 
Some scripts to check:

koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/intranet-tmpl/prog/js/basketgroup.js
koha-tmpl/intranet-tmpl/prog/js/prevent_submit.js
koha-tmpl/intranet-tmpl/prog/js/staff-global.js
koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt

See also
https://developer.mozilla.org/en-US/docs/Web/Events/keypress
Comment 1 Katrin Fischer 2023-09-23 09:56:49 UTC 
Most mentions of keypress now are in JS libraries, but we have some in our own files:

koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/intranet-tmpl/prog/js/staff-global.js
koha-tmpl/intranet-tmpl/prog/js/subscription-add.js
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
koha-tmpl/opac-tmpl/bootstrap/js/global.js
Comment 2 Owen Leonard 2024-04-11 17:09:13 UTC 

*** This bug has been marked as a duplicate of bug 36580 ***
Comment 3 Emily Lamancusa (emlam) 2024-04-11 17:18:22 UTC 
I don't think this is a duplicate of 36580, exactly, though they're closely related. This bug was about replacing the deprecated keypress event with a keydown event(?) instead.

The instance that prompted me to file 36580 already uses keydown rather than keypress (I think), but uses deprecated methods of identifying which key.
Comment 4 Owen Leonard 2024-04-11 17:26:01 UTC 
I assumed that if we were going to address deprecated key events we would do so in one place.