Bug 22283 - Translation file
Summary: Translation file
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: 18.11
Hardware: All All
: P1 - high major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-06 17:39 UTC by ducry.remy
Modified: 2020-01-06 20:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ducry.remy 2019-02-06 17:39:19 UTC
There is a problem with the translation file with 
 problem of quotas: During the generation of the cache files fr (generation 1 to 2) 1)misc/translator/po/fr-FR-staff-prog.po 2 times -> intranet/htdocs/intranet-tmpl/prog/fr-FR/modules/members/memberentrygen.tt
Comment 1 Katrin Fischer 2019-02-06 21:23:29 UTC
Hi, I am sorry, but I don't understand the problem yet.

Do you have problems installing or translating fr-FR?

If it is installing, which is your exact version and how did you try to install?
if it's translating, can you add a link to the problem you see?
Comment 2 ducry.remy 2019-02-08 11:05:05 UTC
Hello Katrin, 
thank you for your answer. I'm sorry I wasn't more specific at the beginning, I'll fix it right now: 
Problem with installation and use (add user in french)
Koha Version 18.11.02.02.000
Ubuntu server version 18.04
Installed via apt-get on Linux

we looked in the conf files and Memcached looks well configured but doesn't run.
Memcached is dependent on Koha because when you uninstall Koha Memcached uninstalls.

Here is more technical information with screenshots (via links) :
Here are the 2 probems (we strongly think it's the same problem):
1) Escape problem on memberentrygen.tt file
2) Memcached does not execute


Here is the server information
http://51.75.27.51/pref-sys.png


the PO file (en-FR-staff-prog.po) generates memberentrygen.tt and removes the escape (\) in front of the double quotes
http://51.75.27.51/fr-FR-staff-prog.po.png (file po without problem )
http://51.75.27.51/memberentrygen.tt.png (file tt with probleme )


Error installing koho or launching command koha-translate --update en-US
http://51.75.27.51/prb-memcache.png




Feel free to ask me for more details if necessary, I am not yet very familiar with programming (I am a student).
Comment 3 Katrin Fischer 2019-02-12 10:18:47 UTC
Hi, did you see any problems apart from the errors (I think mostly warnings)?

Please try to change the "" in your po file to '' to avoid issues for now.
Comment 4 ducry.remy 2019-02-12 13:53:59 UTC
(In reply to Katrin Fischer from comment #3)
> Hi, did you see any problems apart from the errors (I think mostly warnings)?
> 
> Please try to change the "" in your po file to '' to avoid issues for now.


Thank you Katryn for your answer, here are some feedback:

1. we have recovered our fr-FR pack from the official repository so isn't this change of quota to be done on this side as a priority? 

2. Considering the elements previously posted, is there anything to change on our server? 

3. Are there any particular things to know depending on the servers? 

4. Is our version of Ubuntu 18.04 for our server suitable for a Koha project?  Is there a version of Ubuntu that should absolutely be used to use Koha under good conditions?

5. For the moment I don't read a solution for our Memcached problem that doesn't run when it seems to be configured for, do you have any?

6. As a reminder, during the installation for Memcached we have this error message: http://51.75.27.51/prb-memcache.png

Thank you in advance for your valuable feedback.
Comment 5 Katrin Fischer 2019-02-27 17:01:54 UTC
Hi,

overall this sounds more like a support request (issue with setup/installation), rather than a bug right now.

Especially your questions from comment#4 are much better suited for the mailing list (http://koha-community.org/support/koha-mailing-lists/), where there will be a lot more people reading your questions. Another option is the #koha IRC channel (http://koha-community.org/get-involved/irc/). 

You can try fix the translation by getting an account for translate.koha-community.org.

Also: You might want to try updating to the latest 18.11 - sometimes there are errors in po files that are fixed by translators between bugfix
Comment 6 Alex Arnaud 2019-02-28 15:06:46 UTC
(In reply to Katrin Fischer from comment #5)
> Hi,
> 
> overall this sounds more like a support request (issue with
> setup/installation), rather than a bug right now.
> 
> Especially your questions from comment#4 are much better suited for the
> mailing list (http://koha-community.org/support/koha-mailing-lists/), where
> there will be a lot more people reading your questions. Another option is
> the #koha IRC channel (http://koha-community.org/get-involved/irc/). 
> 
> You can try fix the translation by getting an account for
> translate.koha-community.org.
> 
> Also: You might want to try updating to the latest 18.11 - sometimes there
> are errors in po files that are fixed by translators between bugfix

I don't know how to treat this but it is sure that the french translation in po/fr-FR-staff-prog.po+17764 has double quotes escaped and this raise javascript errors when editing a patron. I'm pretty sure we lost a feature (didn't test more). This has been introduced by commit 6a815c8fdb0f9b6f2004aecea2af753cb2f1f539 (Translation updates for Koha 18.11.00)
Comment 7 Katrin Fischer 2019-02-28 15:19:09 UTC
Hi Alex, 

do you have time to look into this more?

- Is this a pootle issue or are our translation tools in Koha broken?
- Are we sure it's not an old problem? The "" are not in the original string, only added by the translation. I know that we were to avoid single quotes around translatable strings to avoid issues with translation (French containing single quotes), so I think this could actually be an old problem instead of a regression, just coming to light here because of the translation. I'd change the translation as a first step.
Comment 8 Alex Arnaud 2019-02-28 15:27:35 UTC
(In reply to Katrin Fischer from comment #7)
> Hi Alex, 
> 
> do you have time to look into this more?
> 
> - Is this a pootle issue or are our translation tools in Koha broken?
> - Are we sure it's not an old problem? The "" are not in the original
> string, only added by the translation. I know that we were to avoid single
> quotes around translatable strings to avoid issues with translation (French
> containing single quotes), so I think this could actually be an old problem
> instead of a regression, just coming to light here because of the
> translation. I'd change the translation as a first step.

IMHO we juste need to write in the po: 
"Changer les préférences de notifications à \\\"Par défaut\\\" pour cette "
instead of:
"Changer les préférences de notifications à \"Par défaut\" pour cette "

With the first one, we keep the double quotes escaped in templates. And it works.
Comment 9 Katrin Fischer 2019-02-28 16:22:42 UTC
(In reply to Alex Arnaud from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > Hi Alex, 
> > 
> > do you have time to look into this more?
> > 
> > - Is this a pootle issue or are our translation tools in Koha broken?
> > - Are we sure it's not an old problem? The "" are not in the original
> > string, only added by the translation. I know that we were to avoid single
> > quotes around translatable strings to avoid issues with translation (French
> > containing single quotes), so I think this could actually be an old problem
> > instead of a regression, just coming to light here because of the
> > translation. I'd change the translation as a first step.
> 
> IMHO we juste need to write in the po: 
> "Changer les préférences de notifications à \\\"Par défaut\\\" pour cette "
> instead of:
> "Changer les préférences de notifications à \"Par défaut\" pour cette "
> 
> With the first one, we keep the double quotes escaped in templates. And it
> works.

Would it not be easier to avoid the quotes overall? I think translators won't be able to tell when they are translating Javascript strings and when they are working on normal text, where this trick won't work. But glad you found a fix! Will you change on pootle?
Comment 10 Alex Arnaud 2019-03-01 10:08:56 UTC
(In reply to Katrin Fischer from comment #9)

> Would it not be easier to avoid the quotes overall? I think translators
> won't be able to tell when they are translating Javascript strings and when
> they are working on normal text, where this trick won't work. But glad you
> found a fix! Will you change on pootle?

Seems that Pootle treat escaping as an error. So i made a suggestion without quotes. 

NoQuote++