Bug 22168 introduced a change to reports CSS which had an unintended effect on the SQL reports edit form.
Created attachment 84845 [details] [review] Bug 22287: Correct new charts CSS This patch reverts some changes to reports CSS from Bug 22168 which were unnecessary and which adversely affected the report add/edit form styling. To test, apply the patch and clear your browser cache if necessary. Go to Reports -> Saved reports and repeat the test plan for Bug 22168: - Run a report which returns more than one column. - On the report results page, click the "Create chart" button. The chart settings form should appear in a modal window. - Click the "Draw" button. The modal should disappear and the chart should be shown. Then test the process for adding or editing an SQL report. The form should be styled in a way consistent with other forms in the staff client.
Created attachment 84892 [details] [review] Bug 22287: Correct new charts CSS This patch reverts some changes to reports CSS from Bug 22168 which were unnecessary and which adversely affected the report add/edit form styling. To test, apply the patch and clear your browser cache if necessary. Go to Reports -> Saved reports and repeat the test plan for Bug 22168: - Run a report which returns more than one column. - On the report results page, click the "Create chart" button. The chart settings form should appear in a modal window. - Click the "Draw" button. The modal should disappear and the chart should be shown. Then test the process for adding or editing an SQL report. The form should be styled in a way consistent with other forms in the staff client. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
Created attachment 85140 [details] [review] Bug 22287: Correct new charts CSS This patch reverts some changes to reports CSS from Bug 22168 which were unnecessary and which adversely affected the report add/edit form styling. To test, apply the patch and clear your browser cache if necessary. Go to Reports -> Saved reports and repeat the test plan for Bug 22168: - Run a report which returns more than one column. - On the report results page, click the "Create chart" button. The chart settings form should appear in a modal window. - Click the "Draw" button. The modal should disappear and the chart should be shown. Then test the process for adding or editing an SQL report. The form should be styled in a way consistent with other forms in the staff client. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
missing 22168 in 18.05.x series. won't backport