In older versions (17.11) the groups of the various sort options were bold, options indented and sections divided by thin lines. In master and 18.11 the display isn't as nice and harder to read.
Created attachment 84980 [details] [review] Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were <optgroup> tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use.
Created attachment 85186 [details] [review] Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were <optgroup> tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 85203 [details] [review] Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were <optgroup> tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series
This could also be seen as a regression to previous versions (bug fix vs. enh) - see first comment.
Okies, I take your point.. pushed to 18.11.x for 18.11.04
Patch doesn't apply cleanly. Please rebase if needed for 18.05.x
(In reply to Jesse Maseto from comment #8) > Patch doesn't apply cleanly. Please rebase if needed for 18.05.x It is not needed.