Created attachment 85248 [details] [review] Bug 22363: Add Koha::ActionLog[s] objects
Created attachment 85249 [details] [review] Bug 22363: Add tests
Created attachment 85250 [details] [review] Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t
Created attachment 85253 [details] [review] Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t
Created attachment 85254 [details] [review] Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t
Created attachment 85261 [details] [review] Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs Test plan: prove t/db_dependent/Circulation.t
Hi Josef - This test failure appears to be unrelated to your work, if you agree I'm happy to sign off your patches. koha-koha@aidev:~/kohaclone$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 28/124 Reducing fine for item 104734 borrower 4329 from 3.5 to 2 - MaxFine reached at /home/koha-koha/kohaclone/C4/Overdues.pm line 570. Use of uninitialized value $actionname in concatenation (.) or string at /home/koha-koha/kohaclone/C4/Log.pm line 85. Reducing fine for item 104734 borrower 4329 from 3.5 to 2 - MaxFine reached at /home/koha-koha/kohaclone/C4/Overdues.pm line 570. Use of uninitialized value $actionname in concatenation (.) or string at /home/koha-koha/kohaclone/C4/Log.pm line 85. # Failed test at t/db_dependent/Circulation.t line 494. # got: '1' # expected: '2' Can't call method "accounttype" on an undefined value at t/db_dependent/Circulation.t line 496. # Looks like your test exited with 2 just after 41. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 84/124 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 512 Tests: 41 Failed: 1) Failed test: 40 Non-zero exit status: 2 Parse errors: Bad plan. You planned 124 tests but ran 41. Files=1, Tests=41, 11 wallclock secs ( 0.03 usr 0.02 sys + 7.98 cusr 0.32 csys = 8.35 CPU) Result: FAIL
(In reply to Andrew Isherwood from comment #7) > Hi Josef - This test failure appears to be unrelated to your work, if you > agree I'm happy to sign off your patches. > > koha-koha@aidev:~/kohaclone$ prove t/db_dependent/Circulation.t > t/db_dependent/Circulation.t .. 28/124 Reducing fine for item 104734 > borrower 4329 from 3.5 to 2 - MaxFine reached at > /home/koha-koha/kohaclone/C4/Overdues.pm line 570. > Use of uninitialized value $actionname in concatenation (.) or string at > /home/koha-koha/kohaclone/C4/Log.pm line 85. > Reducing fine for item 104734 borrower 4329 from 3.5 to 2 - MaxFine reached > at /home/koha-koha/kohaclone/C4/Overdues.pm line 570. > Use of uninitialized value $actionname in concatenation (.) or string at > /home/koha-koha/kohaclone/C4/Log.pm line 85. > > # Failed test at t/db_dependent/Circulation.t line 494. > # got: '1' > # expected: '2' > Can't call method "accounttype" on an undefined value at > t/db_dependent/Circulation.t line 496. > # Looks like your test exited with 2 just after 41. > t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) > Failed 84/124 subtests > > Test Summary Report > ------------------- > t/db_dependent/Circulation.t (Wstat: 512 Tests: 41 Failed: 1) > Failed test: 40 > Non-zero exit status: 2 > Parse errors: Bad plan. You planned 124 tests but ran 41. > Files=1, Tests=41, 11 wallclock secs ( 0.03 usr 0.02 sys + 7.98 cusr 0.32 > csys = 8.35 CPU) > Result: FAIL Hm, this one is not related with my patches, but yesterday I had it all green, I'll try it again, but it may be caused by some data problem? Just guessing....
Created attachment 85594 [details] [review] Bug 22363: Add Koha::ActionLog[s] objects Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 85595 [details] [review] Bug 22363: Add tests Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 85596 [details] [review] Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 85597 [details] [review] Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
(In reply to Andrew Isherwood from comment #12) > > Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Thanks for testing Andrew!
Created attachment 85632 [details] [review] Bug 22363: (follow-up) Fix pod
Created attachment 85633 [details] [review] Bug 22363: Add Koha::ActionLog[s] objects Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85634 [details] [review] Bug 22363: Add tests Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85635 [details] [review] Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85636 [details] [review] Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85637 [details] [review] Bug 22363: (follow-up) Fix pod Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85749 [details] [review] Bug 22363: Add Koha::ActionLog[s] objects Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85750 [details] [review] Bug 22363: Add tests Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85751 [details] [review] Bug 22363: Use Koha::ActionLogs->search instead of GetLogs in log viewer Test plan: 1) Use log viewer, try different parameters 2) Try screen and file export 3) prove t/db_dependent/Koha/ActionLogs.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85752 [details] [review] Bug 22363: Update Circulation.t to use Koha::ActionLogs instead of GetLogs Test plan: prove t/db_dependent/Circulation.t Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85753 [details] [review] Bug 22363: (follow-up) Fix pod Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Rebased needed because of bug 21206
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.