Now we have some due dates formatted as datetime, and some shows time part only when it is hourly loan (as_due_date = 1 param of KohaDates filter is used) This should be same for all due dates across whole system, as_due_date should be used everywhere
Created attachment 85331 [details] [review] Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) batch checkouts 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore
(In reply to Josef Moravec from comment #1) Everything looks like it's working well except this page: > 3) batch checkouts I get an error on that page. > Note: I suspect the moremember-receipt.tt template is not used anymore Yes, which is causing a conflict when apply this patch!
Created attachment 149722 [details] [review] Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) <already fixed> 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149723 [details] [review] Bug 22375: (follow-up) Format even more due dates consistently To test: Create some checkouts in future and past, make sure to include some with a time != 23:59.CirculateILL Verify that the due date is displayed correctly on: * Catalog detail page > Items tab > Checkout status * Circulation start page > Renew > Renew one of your checkouts > dialog message * ILL request page: requires ILL setup and CirculateILL system preference * Patron acccount in staff > Print > Print summary * Catalog detail page > Holds > search for patron > due date on checked out items * Recalls: * Activate UseRecalls system preference, set up circulation rules to allow recalls * Checkout an item to another user * In the OPAC, place a recall on that record with yor use * Check "Recall a specific item" * Verify due date in item list * Place recall on checked out item * Patron account in OPAC > Recalls history (due date might have been changed through recall) * OPAC patron account > Summary > Overdue tab * Self checkout: * Activate WebBasedSelfCheck * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl * Log in > Tab checkouts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Owen Leonard from comment #2) > (In reply to Josef Moravec from comment #1) > > Everything looks like it's working well except this page: > > > 3) batch checkouts > > I get an error on that page. This file is no longer included in the patch set (already fixed). > > Note: I suspect the moremember-receipt.tt template is not used anymore > > Yes, which is causing a conflict when apply this patch! This file has been deleted meanwhile and is also not included. I found some more and wrote up a follow-up.
Created attachment 150655 [details] [review] Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) <already fixed> 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 150656 [details] [review] Bug 22375: (follow-up) Format even more due dates consistently To test: Create some checkouts in future and past, make sure to include some with a time != 23:59.CirculateILL Verify that the due date is displayed correctly on: * Catalog detail page > Items tab > Checkout status * Circulation start page > Renew > Renew one of your checkouts > dialog message * ILL request page: requires ILL setup and CirculateILL system preference * Patron acccount in staff > Print > Print summary * Catalog detail page > Holds > search for patron > due date on checked out items * Recalls: * Activate UseRecalls system preference, set up circulation rules to allow recalls * Checkout an item to another user * In the OPAC, place a recall on that record with yor use * Check "Recall a specific item" * Verify due date in item list * Place recall on checked out item * Patron account in OPAC > Recalls history (due date might have been changed through recall) * OPAC patron account > Summary > Overdue tab * Self checkout: * Activate WebBasedSelfCheck * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl * Log in > Tab checkouts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD amended patch - removed 'fda' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thx, Jonathan :)
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Merge conflicts in 22.05.x, no backport.