Bug 22397 - Wrong message in koha-sip --start
Summary: Wrong message in koha-sip --start
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 18562
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-22 14:31 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2020-06-04 20:32 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 22397: Wrong message in koha-sip --start (986 bytes, patch)
2019-02-22 14:33 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 22397: Wrong message in koha-sip --start (1.04 KB, patch)
2019-02-22 15:16 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2019-02-22 14:31:24 UTC 
A copy and paste error made the SIP command mention 'Zebra' :-D
Comment 1 Tomás Cohen Arazi (tcohen) 2019-02-22 14:33:03 UTC 
Created attachment 85530 [details] [review]
Bug 22397: Wrong message in koha-sip --start

This patch makes koha-sip --start calls mention 'SIP server' instead of
the wrong 'Zebra daemon'.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Jonathan Druart 2019-02-22 15:16:07 UTC 
Created attachment 85564 [details] [review]
Bug 22397: Wrong message in koha-sip --start

This patch makes koha-sip --start calls mention 'SIP server' instead of
the wrong 'Zebra daemon'.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2019-02-22 15:16:51 UTC 
Trivial, skipping QA.
Comment 4 Nick Clemens (kidclamp) 2019-02-26 14:41:33 UTC 
Awesome work all!

Pushed to master for 19.05
Comment 5 Martin Renvoize (ashimema) 2019-03-01 11:15:46 UTC 
Pushed to 18.11.x for 18.11.04
Comment 6 Jesse Maseto 2019-03-08 19:15:18 UTC 
Patch not needed for 18.05.x.