Attribute "for" of label tag should contain form input id, not name.
Created attachment 85593 [details] [review] Bug 22404: Fix parameter "for" of labels in subscription add form Attribute "for" of tag labelshould contain input id, not name. Test plan: 1) Go to serials -> add subscription second step 2) Click on labels of these three fields: - First issue publication date - Subscription start date - Subscription end date --> without patch, nothing happen --> with path, the datepicker is shown
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 85721 [details] [review] Bug 22404: Fix parameter "for" of labels in subscription add form Attribute "for" of tag labelshould contain input id, not name. Test plan: 1) Go to serials -> add subscription second step 2) Click on labels of these three fields: - First issue publication date - Subscription start date - Subscription end date --> without patch, nothing happen --> with path, the datepicker is shown Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Useful one, thanks Josef !
Created attachment 85805 [details] [review] Bug 22404: Fix parameter "for" of labels in subscription add form Attribute "for" of tag labelshould contain input id, not name. Test plan: 1) Go to serials -> add subscription second step 2) Click on labels of these three fields: - First issue publication date - Subscription start date - Subscription end date --> without patch, nothing happen --> with path, the datepicker is shown Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
this is not broken in 18.05 but I assumed having the labels correct named could be helpful in the future. backported to 18.05.x for 18.05.11