Created attachment 85724 [details] timeout_screenshot Removing multiple items from basket.pl on the staff client causes the browser to timeout. (see attached) I can recreate this in both Firefox and Chrome.
Caused by commit c9a7b6742b970d1e605f84ff001f609ddda8eaa2 Bug 19290: Browse selected bibliographic records - Staff interface
Created attachment 86110 [details] [review] Bug 22419: Records listed twice when select/unselect all from the cart It fixes a browser timeout when records are removed from the cart. The onchange event already call selRecord. Test plan: Launch a search Add all the result to your cart Open the cart Click "select all" Then remove them all from your cart => Without this patch the action will timeout => With this patch applied the action is immediate
Created attachment 86113 [details] [review] Bug 22419: Records listed twice when select/unselect all from the cart It fixes a browser timeout when records are removed from the cart. The onchange event already call selRecord. Test plan: Launch a search Add all the result to your cart Open the cart Click "select all" Then remove them all from your cart => Without this patch the action will timeout => With this patch applied the action is immediate Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Hi Lucas, please change the status to 'signed off' when you sign-off :)
Created attachment 86129 [details] [review] Bug 22419: Records listed twice when select/unselect all from the cart It fixes a browser timeout when records are removed from the cart. The onchange event already call selRecord. Test plan: Launch a search Add all the result to your cart Open the cart Click "select all" Then remove them all from your cart => Without this patch the action will timeout => With this patch applied the action is immediate Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
backported to 18.05.x for 18.05.11