In record detail page, item location is displayed with CSS using class "shelvingloc". Use this class in virtual shelves and cataloguing search.
In fact many places at intranet and OPAC can use this class
Created attachment 85861 [details] [review] Bug 22422: improve item location display with class "shelvingloc" In record detail page, item location is displayed with CSS using class "shelvingloc". Many many places at intranet and OPAC can use this class. It allows to change display in all places using CSS customisation. This patch removes the CSS "display:block" for class "shelvingloc". Some places where using "inline" to correct the display. I think the display should not be managed in template. So it will be inline by default and it can be changed by custom CSS, on all places or depending on a selctor. Test plan : 1) Compile SCSS to CSS 2) Add to preferences IntranetUserCSS and OPACUserCSS : .shelvingloc { color:red } 3) Go to pages impacted by patch, be sure to look at cart with "more details" 4) You see item location italic and red
Created attachment 86280 [details] [review] Bug 22422: improve item location display with class "shelvingloc" In record detail page, item location is displayed with CSS using class "shelvingloc". Many many places at intranet and OPAC can use this class. It allows to change display in all places using CSS customisation. This patch removes the CSS "display:block" for class "shelvingloc". Some places where using "inline" to correct the display. I think the display should not be managed in template. So it will be inline by default and it can be changed by custom CSS, on all places or depending on a selctor. Test plan : 1) Compile SCSS to CSS 2) Add to preferences IntranetUserCSS and OPACUserCSS : .shelvingloc { color:red } 3) Go to pages impacted by patch, be sure to look at cart with "more details" 4) You see item location italic and red Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 86338 [details] [review] Bug 22422: improve item location display with class "shelvingloc" In record detail page, item location is displayed with CSS using class "shelvingloc". Many many places at intranet and OPAC can use this class. It allows to change display in all places using CSS customisation. This patch removes the CSS "display:block" for class "shelvingloc". Some places where using "inline" to correct the display. I think the display should not be managed in template. So it will be inline by default and it can be changed by custom CSS, on all places or depending on a selctor. Test plan : 1) Compile SCSS to CSS 2) Add to preferences IntranetUserCSS and OPACUserCSS : .shelvingloc { color:red } 3) Go to pages impacted by patch, be sure to look at cart with "more details" 4) You see item location italic and red Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
cant rebase for 18.05.x deleted by us: ../../../css/src/staff-global.scss ../../../../../opac-tmpl/bootstrap/css/src/opac.scss
(In reply to Lucas Gass from comment #7) > cant rebase for 18.05.x > > deleted by us: ../../../css/src/staff-global.scss > ../../../../../opac-tmpl/bootstrap/css/src/opac.scss Ah indeed, use of SCSS is new. I think its not worth creating a rebased patch
The translation trick used here doesn't appear to work in 18.11: [% tnx('{count} item', '{count} items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | html %][% IF ( SEARCH_RESULT.availablecount ) %], [% SEARCH_RESULT.availablecount | html %] available:[% ELSE %], None available[% END %] This appears untranslated for us still in 18.11.16 and the po file is there and transalted, I think it's not used maybe? It means availability in staff results is now showing partially in English - which is quite prominent :( I filed a new bug 25517.
(In reply to Katrin Fischer from comment #9) > The translation trick used here doesn't appear to work in 18.11: > > [% tnx('{count} item', '{count} > items', SEARCH_RESULT.items_count, {count = SEARCH_RESULT.items_count}) | > html %][% IF ( SEARCH_RESULT.availablecount ) %], [% > SEARCH_RESULT.availablecount | html %] available:[% ELSE %], None > available[% END %] > > This appears untranslated for us still in 18.11.16 and the po file is there > and transalted, I think it's not used maybe? > > It means availability in staff results is now showing partially in English - > which is quite prominent :( > > I filed a new bug 25517. I was wrong, this line comes from Bug 21789: Example usage of I18N Template::Toolkit plugin. Sorry.