Currently item search has "lost" as a yes or no field. Lost should be searchable just like "not for loan," listing all the authorized values configured. Search results should include a column for "Lost."
Created attachment 88782 [details] [review] Bug 22424: Add search by all lost statuses to item search This patch changes the item search form so that searching by lost status includes options for all lost authorised values instead of just "yes" or "no." To test you should have multiple authorized values for LOST. - Apply the patch and open the item search form. - Test searches which limit by lost status. Confirm that results are correctly limited. - Confirm that lost statuses are correctly displayed in the search results. - Confirm that in the search results table, the column header for "Lost" includes a dropdown menu for filtering by all available authorized values for lost. - Test the CSV export function and confirm that lost status is correctly exported.
Created attachment 88850 [details] [review] Bug 22424: Add search by all lost statuses to item search This patch changes the item search form so that searching by lost status includes options for all lost authorised values instead of just "yes" or "no." To test you should have multiple authorized values for LOST. - Apply the patch and open the item search form. - Test searches which limit by lost status. Confirm that results are correctly limited. - Confirm that lost statuses are correctly displayed in the search results. - Confirm that in the search results table, the column header for "Lost" includes a dropdown menu for filtering by all available authorized values for lost. - Test the CSV export function and confirm that lost status is correctly exported. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
If the lost value is not set, the search results will display 0, same for the CSV export. The entry 'Lost' is repeated in the datatables filter on top of the list. Maybe this needs to be renamed "Status" to be less confusing. Or "Not lost"? Actually, in that context: I also think the "Status" column should be "not for loan" - but that belongs on a different bug maybe. :)
Created attachment 89025 [details] [review] Bug 22424: (follow-up) Show blank value for empty status This patch updates the screen and CSV output of item searches so that if the item does not have a lost status a blank table cell is shown instead of "0." This patch also amends the table headers so that "Not for loan" statuses are explicitly labeled as such, and the "Lost" column has the header "Lost status." To test, apply the patch and perform an item search in the staff client which will return results with notforloan and lost items. Verify that the values display correctly in both onscreen and CSV output. Verify that the column headers look correct.
Created attachment 89053 [details] [review] Bug 22424: Add search by all lost statuses to item search This patch changes the item search form so that searching by lost status includes options for all lost authorised values instead of just "yes" or "no." To test you should have multiple authorized values for LOST. - Apply the patch and open the item search form. - Test searches which limit by lost status. Confirm that results are correctly limited. - Confirm that lost statuses are correctly displayed in the search results. - Confirm that in the search results table, the column header for "Lost" includes a dropdown menu for filtering by all available authorized values for lost. - Test the CSV export function and confirm that lost status is correctly exported. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 89054 [details] [review] Bug 22424: (follow-up) Show blank value for empty status This patch updates the screen and CSV output of item searches so that if the item does not have a lost status a blank table cell is shown instead of "0." This patch also amends the table headers so that "Not for loan" statuses are explicitly labeled as such, and the "Lost" column has the header "Lost status." To test, apply the patch and perform an item search in the staff client which will return results with notforloan and lost items. Verify that the values display correctly in both onscreen and CSV output. Verify that the column headers look correct. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thank you for the quick follow-up, Owen!
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.