See bug 18936 comment 33. If C4::Installer::column_exists is called with a table that has been removed, the methods will print an error. I think it should early return if the table does not exist (not an exception, we do not want to make more complex the update DB script)
Created attachment 86240 [details] [review] Bug 22472: Add tests
Created attachment 86241 [details] [review] Bug 22472: Make column_exists early return if the table does not exist On the way we move TableExists to C4::Installer, where it belongs to.
Created attachment 87381 [details] [review] Bug 22472: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 87382 [details] [review] Bug 22472: Make column_exists early return if the table does not exist On the way we move TableExists to C4::Installer, where it belongs to. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
FAIL pod coverage POD is missing for TableExists Is a false positive as the method was only moved in the file. I think renaming it to table_exists might be a nice clean-up, but could be done separately.
Created attachment 87512 [details] [review] Bug 22472: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87513 [details] [review] Bug 22472: Make column_exists early return if the table does not exist On the way we move TableExists to C4::Installer, where it belongs to. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sane and sensible change.. no regressions found and I agree that the function rename would be nice but can be in another bug. Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
Created attachment 89566 [details] [review] Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 89567 [details] [review] Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472