Reading field mappings uses the general config as the base for both, which makes them accidentally share the field mappings.
Created attachment 86278 [details] [review] Bug 22474: Clone field config before adding fields to it Test plain: 1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d" 2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings 3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v"
Created attachment 86664 [details] [review] Bug 22474: Clone field config before adding fields to it Test plain: 1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d" 2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings 3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v" Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se>
Created attachment 87972 [details] [review] Bug 22474: Clone field config before adding fields to it Test plain: 1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d" 2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings 3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v" Signed-off-by: Björn Nylén <bjorn.nylen@ub.lu.se> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
not backporting ES bugs to 18.05.x, not backporting