We have been getting some random failures here. We are setting some barcodes and cardnumbers by hand as well as deleting lots of data. We should clean this up to see if it helps.
Created attachment 86461 [details] [review] Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense
Created attachment 86476 [details] [review] Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 86527 [details] [review] Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Eminently sane, Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
can't prove t/db_dependent/DecreaseLoanHighHolds.t in 18.05.x 1..17 ok 1 - userenv set Can't locate object method "build_sample_biblio" via package "t::lib::TestBuilder" at t/db_dependent/DecreaseLoanHighHolds.t line 74. # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/17 subtests Test Summary Report ------------------- t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 17 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.18 cusr 0.16 csys = 1.36 CPU) Result: FAIL not backporting to 18.05.x