Some libraries have been using the public notes field to point to electronic resources, this functionality has been removed by HTML filtering the content. We should allow the use of a $raw filter on these fields as they can only be entered by staff
Created attachment 87127 [details] [review] Attachment to Bug 22501 - OPAC course reserves notes should allow html links Bug 22501: OPAC course reserves notes should allow html links Test Plan: 1. Add a new course a put '<a href=""></a>' in the public not field. 2. Go to the course in the OPAC. 3. Notice that the HTML displays literally 4. Apply patch and reload page 5. The <a> tag should render as HTML
Created attachment 87329 [details] [review] Bug 22501: OPAC course reserves notes should allow html links Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87380 [details] [review] Bug 22501: OPAC course reserves notes should allow html links Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This fixes the note on course level, from the description I was wondering if it should be the public note on course reserve item level? It also only fixes the OPAC side, but still displays escaped in staff. I think both should match to give the correct preview of the entered HTML code.
Created attachment 87658 [details] [review] Bug 22501: (QA Follow-up) use $raw for the note in the intranet
Yep I think we should have this in the intranet too, I've added a follow up for that. It might be scope-creep to change the item level notes, but that could definitely go on another bug.
Hi Lucas, please use the QA tools on your patches - it will show you if there are any complaints. In this case, there is a small 'typo' in the first commit message. I will fix it.
Created attachment 87735 [details] [review] Bug 22501: OPAC course reserves notes should allow html links Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 87736 [details] [review] Bug 22501: (QA follow-up) use $raw for the note in the intranet Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 87737 [details] [review] Bug 22501: Add raw filter to course reserves summary page Fixes another place where the public note is shown: - Course reserves module start/summary page
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
Created attachment 88333 [details] [review] Bug 22501: (follow-up) Use raw filter for course note on details page
Hi Nick, what more is needed here? (additional_work_needed)
(In reply to Katrin Fischer from comment #14) > Hi Nick, what more is needed here? (additional_work_needed) I added an additional patch, the notes in course details were still filtered, it should be pushed to all versions
not backporting to 18.05.x
(In reply to Nick Clemens from comment #15) > (In reply to Katrin Fischer from comment #14) > > Hi Nick, what more is needed here? (additional_work_needed) > > I added an additional patch, the notes in course details were still > filtered, it should be pushed to all versions (In reply to Nick Clemens from comment #13) > Created attachment 88333 [details] [review] [review] > Bug 22501: (follow-up) Use raw filter for course note on details page Follow-up pushed to master
Follow-up pushed to 18.11.x for 18.11.05