Using "_doc" despite "data" in Elastic index. (_doc is not allowed in 5.x version (but we need to have 6.x elastic asap)...)
Created attachment 86908 [details] [review] Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct.
(In reply to Owen Leonard from comment #2) > Created attachment 86908 [details] [review] [review] Sorry, wrong bug number!
Since it's not necessary to use the type name in Elasticsearch 7, it's possible to use data as the type name in Elasticsearch 6, upgrade to Elasticsearch 7, and then no longer use the type name. It would be possible to check if a new index is being created and then use _doc for the type name, but it could complicate things if the indexes had different type names and it was necessary to check which type name they had before using them. One can always recreate the indexes in Elasticsearch 7 if desired.
Which workflow does this break or triggers a warning?
(In reply to Victor Grousset/tuxayo from comment #5) > Which workflow does this break or triggers a warning? In ES6, the type is specified in the URL to index a single record, but in ES7, _doc should be used instead. So if ES6 has a type of _doc, the URL for indexing single records doesn't need to be changed when upgrading to ES7. Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing.
> Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing. So compat with ES7 is already ok for this? So no action needed?
(In reply to Victor Grousset/tuxayo from comment #7) > > Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing. > > So compat with ES7 is already ok for this? So no action needed? That's correct, this bug can be closed.
Hurray! Thanks for the analysis :)