Bug 22520 - Be Elastic compliant 7.x and 8.x (_doc)
Summary: Be Elastic compliant 7.x and 8.x (_doc)
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 25439
  Show dependency treegraph
 
Reported: 2019-03-15 14:44 UTC by claire.hernandez@biblibre.com
Modified: 2022-12-12 21:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22560: Forgotten password "token expired" page still shows boxes to reset password (2.40 KB, patch)
2019-03-22 13:27 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description claire.hernandez@biblibre.com 2019-03-15 14:44:31 UTC

    
Comment 1 claire.hernandez@biblibre.com 2019-03-15 14:44:36 UTC
Using "_doc" despite "data" in Elastic index.

(_doc is not allowed in 5.x version (but we need to have 6.x elastic asap)...)
Comment 2 Owen Leonard 2019-03-22 13:27:15 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2019-03-22 13:28:17 UTC
(In reply to Owen Leonard from comment #2)
> Created attachment 86908 [details] [review] [review]

Sorry, wrong bug number!
Comment 4 Kevin Carnes 2022-02-08 14:36:02 UTC
Since it's not necessary to use the type name in Elasticsearch 7, it's possible to use data as the type name in Elasticsearch 6, upgrade to Elasticsearch 7, and then no longer use the type name.

It would be possible to check if a new index is being created and then use _doc for the type name, but it could complicate things if the indexes had different type names and it was necessary to check which type name they had before using them.

One can always recreate the indexes in Elasticsearch 7 if desired.
Comment 5 Victor Grousset/tuxayo 2022-02-18 22:15:27 UTC
Which workflow does this break or triggers a warning?
Comment 6 Kevin Carnes 2022-02-22 12:52:46 UTC
(In reply to Victor Grousset/tuxayo from comment #5)
> Which workflow does this break or triggers a warning?

In ES6, the type is specified in the URL to index a single record, but in ES7, _doc should be used instead. So if ES6 has a type of _doc, the URL for indexing single records doesn't need to be changed when upgrading to ES7.

Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing.
Comment 7 Victor Grousset/tuxayo 2022-02-23 13:03:44 UTC
> Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing.

So compat with ES7 is already ok for this? So no action needed?
Comment 8 Kevin Carnes 2022-02-23 14:46:48 UTC
(In reply to Victor Grousset/tuxayo from comment #7)
> > Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing.
> 
> So compat with ES7 is already ok for this? So no action needed?

That's correct, this bug can be closed.
Comment 9 Victor Grousset/tuxayo 2022-02-24 18:57:41 UTC
Hurray!

Thanks for the analysis :)