To recreate: 1 - Edit permissions for a user 2 - Check a top level permission 3 - Uncheck some sub permissions 4 - Note the top level is still checked 5 - Save 6 - Edit the permissions agin 7 - User has top level permission
Just ran into this as well - It's dangerous as it could go unnoticed easily and having to uncheck the top permission means you have to set all sub-permissions again, which is error-prone.
Created attachment 87606 [details] [review] Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked.
Created attachment 87607 [details] [review] Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87670 [details] [review] Bug 22553: Unchecking a subpermission does not uncheck the top level permission This patch makes a minor change to the set permissions page's JavaScript so that unchecking a subpermission will uncheck the top level permission. To test, apply the patch and open the "Set permissions" page for a patron. - Expand a permission with multiple subpermissions. - Check the top level permission. All subpermissions should be checked. - Uncheck one of the subpermissions. The top level permission should now be unchecked. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Bug in enhancement not in 18.11.x series.