The blue box on the password recovery page that tells users what requirements new passwords must have doesn't show all of the rules that might be in effect. The infobox currently only shows the length requirements and should show the requirements enacted by RequireStrongPassword, if that is set.
Created attachment 86907 [details] [review] Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password.
Created attachment 86978 [details] [review] Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86980 [details] [review] Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
pushed to 18.05.x for 18.05.12