The 'Rep' accounttype has not been set in Koha for some time and it should now be safe to remove all references to it. History: 'Rep' used to mean 'Replaced' and at some point may have been used to denote when a lost book had been replaced.
Created attachment 86922 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87052 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Add a db rev just like the other report? Report changed number ?
Created attachment 87194 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87195 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87205 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87206 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87207 [details] [review] Bug 22564: Add UI handling for 'Replaced'
Back to signed off.. I've added the requested DB update (and also added some UI display just in case it actually picks any up).. Might be a useful 'status' in the future anyway.
Created attachment 87629 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87630 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87631 [details] [review] Bug 22564: Add UI handling for 'Replaced'
Freshly re-based and ready for QA
Created attachment 87793 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87794 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87795 [details] [review] Bug 22564: Add UI handling for 'Replaced'
Freshly rebased
Dependency does not apply
Created attachment 87866 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87867 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87868 [details] [review] Bug 22564: Add UI handling for 'Replaced' Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 88219 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 88220 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 88221 [details] [review] Bug 22564: Add UI handling for 'Replaced' Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Dependencies now in master and patches freshly rebased here.
The patch description says that Rep is not used, but it's not removed here either. Is there a way to set it or a plan to bring it back? Again, setting Failed QA to get attention, reads well :)
So.. My understanding of the original feature was that 'Rep' was a form of 'Credit' which wrote off a replacement fee recording that the patron had brought in a new copy of the item themselves and given it to the library as apposed to paying the fee for the library to replace it. I don't believe this has functioned fully in around 14 years (that's as far back as I went in the git logs) I do think it's a nice thing to attempt to correct any left over data such that it will display correctly should there be any, but I don't think this bug should be held up by the requirement to re-implement that long broken process. I sort of like the idea of re-visiting that process at some point however so this status could serve as a foundation for that. Setting back to SO in the hopes we can move this one along and I'll add a bug describing the per-sieved workflow for the enhancement/restoration of the feature.
Created attachment 88342 [details] [review] Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 88343 [details] [review] Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 88344 [details] [review] Bug 22564: Add UI handling for 'Replaced' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 88345 [details] [review] Bug 22564: (QA follow-up) Correct copy-paste message We should be replacing Rep here ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.