As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template.
Created attachment 87095 [details] [review] Bug 22586: fix IntranetReportsHomeHTML filter
Created attachment 87096 [details] [review] Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html
Created attachment 87116 [details] [review] Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams <george@nekls.org>
Tested successfully on ByWater sandboxes
Created attachment 87169 [details] [review] Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
not backporting this to the 18.05.x series