Created attachment 87070 [details] BrokenXml returned from GetPatronInfo with show_loans=1 If value in more_subfields_xml contains xml opening and closing tags then xml structure in broken and response cannot be read by the third-party software. I suggest removing <more_subfields_xml> from the response as it is done for GetRecords.
Created attachment 87074 [details] [review] Bug 22597 : Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice
Created attachment 87476 [details] [review] Bug 22597 : Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signing off, but I think for QA a unit test will be needed.
Created attachment 87875 [details] [review] Bug 22597: Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Katrin Fischer from comment #3) > Signing off, but I think for QA a unit test will be needed. Hmm. For this very small change I will not insist on that. Note that GetPatronInfo is tested and still passes.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05