The filter on the 'Transactions' tab is no longer working. Clicking on it will change the text, but the table will not be fltered. To test: - Go to an account with some paid and unpaid fines and fees - Go to Accounting tab - Click filter link on top of Transactions table - Verify nothing happens I couldn't spot a Javascript error in the console.
Created attachment 87618 [details] [review] Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff This patch changes a parameter in the function which filters the DataTable of transactions. The addition of more columns to the table changed the index of the column which is being filtered. To test, apply the patch and locate a patron who has multiple fines or charges, some of them paid. Go to Accounting -> Transactions. Test the "Filter paid transactions" link. Table rows which show "0.00" in the "Oustanding" column should be hidden.
Created attachment 87655 [details] [review] Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff This patch changes a parameter in the function which filters the DataTable of transactions. The addition of more columns to the table changed the index of the column which is being filtered. To test, apply the patch and locate a patron who has multiple fines or charges, some of them paid. Go to Accounting -> Transactions. Test the "Filter paid transactions" link. Table rows which show "0.00" in the "Oustanding" column should be hidden. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87665 [details] [review] Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff This patch changes a parameter in the function which filters the DataTable of transactions. The addition of more columns to the table changed the index of the column which is being filtered. To test, apply the patch and locate a patron who has multiple fines or charges, some of them paid. Go to Accounting -> Transactions. Test the "Filter paid transactions" link. Table rows which show "0.00" in the "Oustanding" column should be hidden. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
I don't think 18.05.x need this as that functionality works fine. Adding the patch breaks it. Not backporting.