Trailing comma in the update statement 349 my $sth_update = $dbh->prepare(q| 350 UPDATE default_borrower_circ_rules 351 SET maxissueqty = ?, 352 maxonsiteissueqty = ?, 353 WHERE categorycode = ? 354 |);
Created attachment 87469 [details] [review] Bug 22648: Fix typo in SQL in smart-rules.pl Fixes 2 SQL statements for setting the maximum number of checkouts possible. To test: - In 18.11 - Verify that setting Default checkout, hold and return policy works - Verfiy that setting Default checkout, ohld and return policy by patron category works
Just did some testing in our 18.11 installation and it doesn't blow up?
I 'think' this is only an issue if you're running in SQL strict modes.. it'll be a nice thing to fix, but hopefully in the wild it's not really causing any problems.
Created attachment 87489 [details] [review] Bug 22648: Fix typo in SQL in smart-rules.pl Fixes 2 SQL statements for setting the maximum number of checkouts possible. To test: - In 18.11 - Verify that setting Default checkout, hold and return policy works - Verfiy that setting Default checkout, ohld and return policy by patron category works Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signing off.
Going straight for PQA as it's a trivial patch.. thanks for reporting Nick and thanks for the quick patch Katrin.
Pushed to 18.11.x for 18.11.05.