Currently the link is only on the number, that can be hard to see and hard to click. I propose to link the name as well. Example: Basket name (1)
Created attachment 87546 [details] [review] Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice.
Created attachment 87547 [details] [review] Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice.
Created attachment 87549 [details] [review] Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88159 [details] [review] Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice improvement, Passing QA
I do however wonder.. are there other places we should make such a change too to be consistent for UX
I plan on doing some more, if noone beats me to it. Already noticed the issue is also on the receive page.
let's do a bunch for 10 years. :)
Created attachment 88246 [details] [review] Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice.
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 88290 [details] [review] Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 88291 [details] [review] Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
(In reply to Liz Rea from comment #9) > Created attachment 88246 [details] [review] [review] > Bug 22664: More making acquisitions links more easily clickable > > To test: > > * create a basket with an order from a staged record, and an order from > a suggestion > * add that basket to a basket group when you close it. > * note that the links to the basket in the first column, the link to the > basket group in the second column, and the link to > the suggester in the summary column are very small (only the ID# is > linked) > * apply this patch, restart the things > * refresh the page, note that the previously ogled links are now bigger > and easier to find and click, and that the links work and such > * rejoice. Looked ok, thanks Liz !
Created attachment 88684 [details] [review] Bug 22664: Link names in order search results instead of numbers To test: Make up some orders, put some in basket groups. Search for your vendor's orders, note that the only thing linking to the order is a tiny number in parentheses. Apply this patch, restart the things. Refresh the results, note that te basket names *and* numbers are linked now. Rejoice. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 88685 [details] [review] Bug 22664: More making acquisitions links more easily clickable To test: * create a basket with an order from a staged record, and an order from a suggestion * add that basket to a basket group when you close it. * note that the links to the basket in the first column, the link to the basket group in the second column, and the link to the suggester in the summary column are very small (only the ID# is linked) * apply this patch, restart the things * refresh the page, note that the previously ogled links are now bigger and easier to find and click, and that the links work and such * rejoice. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.