When creating an item as part of receiving in serials (serials-edit.pl), the source of classification will always follow the DefaultClassificationSource system preference. In contrast, when creating an item via additem.pl we can specify a default value via the framework that differs from the DefaultClassificationSource syspref. This discrepancy prevents libraries from easily applying a different classification source for their serials than they use for the rest of their collection.
Oh, I forgot to include the fact that default values for *other* 952 subfields are correctly applied from the framework when creating an item via serials. The 952$2, source of classification, appears to be an exception.
Created attachment 89148 [details] [review] Bug 22667: Pick default value from framework for cn_source If the cn_source has a default value defined in the framework it will not be used when ordering or receiving serials. Test plan: Set the pref DefaultClassificationSource to Library of congress Define a default value=ddc (for Dewey) for the ACQ and default framework Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is selected by default (the default value from the ACQ framework is used) Receive a serial and confirm that Dewey is selected by default
Created attachment 93540 [details] [review] Bug 22667: Pick default value from framework for cn_source If the cn_source has a default value defined in the framework it will not be used when ordering or receiving serials. Test plan: Set the pref DefaultClassificationSource to Library of congress Define a default value=ddc (for Dewey) for the ACQ and default framework Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is selected by default (the default value from the ACQ framework is used) Receive a serial and confirm that Dewey is selected by default Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 93849 [details] [review] Bug 22667: Pick default value from framework for cn_source If the cn_source has a default value defined in the framework it will not be used when ordering or receiving serials. Test plan: Set the pref DefaultClassificationSource to Library of congress Define a default value=ddc (for Dewey) for the ACQ and default framework Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is selected by default (the default value from the ACQ framework is used) Receive a serial and confirm that Dewey is selected by default Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00