For payments we currently have: [%- CASE 'Pay' -%]<span>Payment, thanks</span> [%- CASE 'Pay00' -%]<span>Payment, thanks (cash via SIP2)</span> [%- CASE 'Pay01' -%]<span>Payment, thanks (VISA via SIP2)</span> [%- CASE 'Pay02' -%]<span>Payment, thanks (credit card via SIP2)</span> After a quick survey on IRC I Propose to remove ", thanks".
Created attachment 87688 [details] [review] Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please
Created attachment 87707 [details] [review] Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Do we also need a database update to fix existing entries?
I checked my database and couldn't find any entries with 'Payment, thanks', my descriptions on payments were empty. I imagine maybe some old databases might have them still, but I don't have an example line to test with - it would be many versions ago.
Created attachment 88191 [details] [review] Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Needs a minor rebase please
Created attachment 88469 [details] [review] Bug 22674: Change wording of payments in the GUI This changes the different versions of "Payment, thanks" to just read "Payment". To test: - Look at the Fines & Charges tables in - OPAC patron account > your fines - Staff patron account > Accounting > Transactions tab - Staff patron account > Accounting > Make a payment tab - Verify all tables display the descriptions correctly - Decide if you like this better than before Yes: sign-off No: comment on the bug please Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Nick Clemens from comment #6) > Needs a minor rebase please Done
(In reply to Josef Moravec from comment #8) > (In reply to Nick Clemens from comment #6) > > Needs a minor rebase please > > Done Thank you, Josef!
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.