Created attachment 87727 [details] Screenshot showing the desired layout The language footer in the OPAC is supposed to appear at the bottom of the screen if there is not enough content to require scrolling to reach the bottom. Instead the language footer is always just below the visible area. I will submit a patch to correct this.
Created attachment 87729 [details] [review] Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly.
Created attachment 87730 [details] [review] Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87733 [details] [review] Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
Not backporting to 18.05.x