The code in sci-main.pl tries to set this, but fails: # Make sure timeout has a reasonable value my $timeout = C4::Context->preference('SelfCheckInTimeout') // 120; $template->param( refresh_timeout => $timeout ); To recreate: 1 - Blank the syspref SelfCheckInTimeout 2 - Attempt to checkin something via sci 3 - Error: Your request included no check-ins. Additionally, it would be nice to be able to return to the main interface if this error is received
Created attachment 88354 [details] [review] Bug 22739: Test SelfCheckInTimeout <> 0, not just defined On sci-main.pl the preference value is tested for 'defined'. This patch tests it is different than empty string too. This was causing a JavaScript syntax error, that made it display a wrong message. To test: 1 - Blank the syspref SelfCheckInTimeout 2 - Attempt to checkin something via sci => FAIL: The 'Your request included no check-ins.' message is printed. 3 - Apply this patch, reload the sci-main.pl page 4 - Attempt to checkin something via sci => SUCCESS: The UI correctly stacks the scanned barcodes 5 - Sign off :-D
Created attachment 88635 [details] [review] Bug 22739: Test SelfCheckInTimeout <> 0, not just defined On sci-main.pl the preference value is tested for 'defined'. This patch tests it is different than empty string too. This was causing a JavaScript syntax error, that made it display a wrong message. To test: 1 - Blank the syspref SelfCheckInTimeout 2 - Attempt to checkin something via sci => FAIL: The 'Your request included no check-ins.' message is printed. 3 - Apply this patch, reload the sci-main.pl page 4 - Attempt to checkin something via sci => SUCCESS: The UI correctly stacks the scanned barcodes 5 - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88636 [details] [review] Bug 22739: Test SelfCheckInTimeout <> 0, not just defined On sci-main.pl the preference value is tested for 'defined'. This patch tests it is different than empty string too. This was causing a JavaScript syntax error, that made it display a wrong message. To test: 1 - Blank the syspref SelfCheckInTimeout 2 - Attempt to checkin something via sci => FAIL: The 'Your request included no check-ins.' message is printed. 3 - Apply this patch, reload the sci-main.pl page 4 - Attempt to checkin something via sci => SUCCESS: The UI correctly stacks the scanned barcodes 5 - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
backported to 18.05.x for 18.05.13