On reserve/request.pl, clicking the green up arrow with a bar (the mouseover reads 'Move hold to top') doesn't move a hold up in priority if there is a waiting hold on the bib. This is a regression between 18.05 and 18.11. As a work-around, the change priority drop-down *does* work in 18.11. The 'move hold up', 'move hold down' and 'move hold to bottom' buttons continue to work as well.
Created attachment 88551 [details] [review] Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the firs tin the loop, not taking into accoutn waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some cleanmup is done to not display the alter priority arrows for waiting holds To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table)
Created attachment 88555 [details] [review] Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the firs tin the loop, not taking into accoutn waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some cleanmup is done to not display the alter priority arrows for waiting holds To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88556 [details] [review] Bug 22753: (QA follow-up) fixing tabs
Created attachment 88641 [details] [review] Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the first in the loop, not taking into account the waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some clean-up is done to not display the alter priority arrows for waiting holds. To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88642 [details] [review] Bug 22753: Fix tabs pointed out by QA script Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
not necessary in 18.05.x, won't backport