Bug 22603 added Koha::Script module to create some userenv when running commands/cronjobs. Patron emailer cronjob from bug 16149 was written before, so it is missing this import.
(In reply to Josef Moravec from comment #1) > Bug 22603 added Koha::Script module to create some userenv when running > commands/cronjobs. Patron emailer cronjob from bug 16149 was written before, > so it is missing this import. In fact it was bug 22600, sorry
Created attachment 88402 [details] [review] Bug 22755: Import Koha::Script into patron_emailer cronjob Test plan: Run patron_emailer.pl cronjob to ensure it is not broken after this patch
Created attachment 88403 [details] [review] Bug 22755: Fix pod in patron_emailer.pl
Created attachment 88524 [details] [review] Bug 22755: Import Koha::Script into patron_emailer cronjob Test plan: Run patron_emailer.pl cronjob to ensure it is not broken after this patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 88525 [details] [review] Bug 22755: Fix pod in patron_emailer.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch Josef.. going straight for PQA as it's a trivial patch. Also, I'm going to log an issue to add a check for a 'use Koha::Script' statement in the QA tools for anything under /scripts
Awesome work all! Pushed to master for 19.05
Dependency not in 18.11.x series.