Created attachment 88449 [details] [review] Bug 22757: Add CodeMirror highlighting on more YAML formatted prferences Test plan: Go to system preferences and ensure the code highlighting is used on these preferences: UpdateNotForLoanStatusOnCheckin BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder
Good catch!
Created attachment 88460 [details] [review] Bug 22757: Add CodeMirror highlighting on more YAML formatted prferences Test plan: Go to system preferences and ensure the code highlighting is used on these preferences: UpdateNotForLoanStatusOnCheckin BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder ItemsDeniedRenewal
Created attachment 88461 [details] [review] Bug 22757: Add CodeMirror highlighting on more YAML formatted prferences Test plan: Go to system preferences and ensure the code highlighting is used on these preferences: UpdateNotForLoanStatusOnCheckin BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder ItemsDeniedRenewal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thanks Owen!
Created attachment 88658 [details] [review] Bug 22757: Add CodeMirror highlighting on more YAML formatted preferences Test plan: Go to system preferences and ensure the code highlighting is used on these preferences: UpdateNotForLoanStatusOnCheckin BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder ItemsDeniedRenewal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.c series