Hi, In marc21, second indicator in field 245 contains number of nonfiling characters. Sort by title (A-Z, Z-A) with ElasticSearch do not considerate this number. Has this problem already been reported? Regards, Marjorie
Note: This works for Zebra, so would be a possible regression.
*** Bug 24362 has been marked as a duplicate of this bug. ***
If alphabetical sort by title is not correct (in that it ignores the 245 second indicator) it should not be offered as an option as it is misleading. One usually sorts by title because there are more records than can easily be reviewed in one page. I have been misled!
Created attachment 99691 [details] [review] Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass
Created attachment 99692 [details] [review] Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass
Created attachment 99693 [details] [review] Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass
Created attachment 99696 [details] [review] Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass Signed-off-by: David Nind <david@davidnind.com>
Created attachment 100270 [details] [review] Bug 22771: Fix mistakes in list of nonfiling character fields
Created attachment 100297 [details] [review] Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass Signed-off-by: David Nind <david@davidnind.com>
Created attachment 100298 [details] [review] Bug 22771: Fix mistakes in list of nonfiling character fields Signed-off-by: David Nind <david@davidnind.com>
Created attachment 101551 [details] [review] Bug 22771: Respect nonfiling indicators for search fields Strip initial characters from search fields in accordance with nonfiling character indicators. To test: 1) Apply patch 2) Run tests in t/Koha/SearchEngine/Elasticsearch.t 3) All tests should pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 101552 [details] [review] Bug 22771: Fix mistakes in list of nonfiling character fields Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 101553 [details] [review] Bug 22771: (QA follow-up) Fix POD Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
QA errors when applied to 19.11.x not backported FAIL Koha/SearchEngine/Elasticsearch.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling FAIL valid Name "Koha::SearchEngine::BIBLIOS_INDEX" used only once: possible typo
(In reply to Joy Nelson from comment #15) > QA errors when applied to 19.11.x not backported > FAIL Koha/SearchEngine/Elasticsearch.pm > OK critic > OK forbidden patterns > OK git manipulation > OK pod > OK pod coverage > OK spelling > FAIL valid > Name "Koha::SearchEngine::BIBLIOS_INDEX" used only once: > possible typo That's a false positive I believe, you can ignore
QA errors ignored. backported to 19.11.x branch for 19.11.05