Order an example with 8 * 16,99 and 42% discount, 19.45% tax. Ordered.pl is doing: get_rounded_price( quantity * price ) Other pages are: quantity * get_rounded_price( price ) The second is more correct I believe
Created attachment 88968 [details] [review] Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match
Thought we resolved these numbers :)
(In reply to Marcel de Rooy from comment #2) > Thought we resolved these numbers :) Baby steps
Created attachment 89327 [details] [review] Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 89422 [details] [review] Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06
missing dependencies for 18.05.x, no backport