Bug 22797 - ILS-DI: GetRecords doesn't work with documented parameter id_type
Summary: ILS-DI: GetRecords doesn't work with documented parameter id_type
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2019-04-28 08:46 UTC by Katrin Fischer
Modified: 2019-11-24 22:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2019-04-28 08:46:53 UTC
I've tried GetRecords from ILS-DI and noticed that the id_type parameter listed doesn't work, although it's listed in documentation.

<GetRecords><code>IllegalParameter</code><message>The parameter id_type is illegal.</message></GetRecords>
Comment 1 Jonathan Druart 2019-04-29 21:01:19 UTC
Works for me:

/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=42&id_type=cardnumber

returns

<LookupPatron><id>51</id></LookupPatron>
Comment 2 Jonathan Druart 2019-04-29 21:11:34 UTC
And /cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=1+2+99999&id_type=item

returns

<dlf:collection xsi:schemaLocation="http://diglib.org/ilsdi/1.1     http://diglib.org/architectures/ilsdi/schemas/1.1/dlfexpanded.xsd"><dlf:record><dlf:bibliographic id="1"/><dlf:items><dlf:item id="1"><dlf:simpleavailability><dlf:identifier>1</dlf:identifier><dlf:availabilitystatus>available</dlf:availabilitystatus><dlf:location>Centerville</dlf:location></dlf:simpleavailability></dlf:item></dlf:items></dlf:record><dlf:record><dlf:bibliographic id="345"/><dlf:items><dlf:item id="2"><dlf:simpleavailability><dlf:identifier>2</dlf:identifier><dlf:availabilitystatus>available</dlf:availabilitystatus><dlf:location>Centerville</dlf:location></dlf:simpleavailability></dlf:item></dlf:items></dlf:record><dlf:record><dlf:bibliographic id="99999"/><dlf:items><dlf:item id="99999"><dlf:simpleavailability><dlf:identifier>99999</dlf:identifier><dlf:availabilitystatus>unknown</dlf:availabilitystatus><dlf:availabilitymsg>Error: could not retrieve availability for this ID</dlf:availabilitymsg></dlf:simpleavailability></dlf:item></dlf:items></dlf:record></dlf:collection>
Comment 3 Jonathan Druart 2019-04-29 21:16:14 UTC
Scratch the last 2 comments, it was not GetRecords.

It is in the POD since the first commit but has never been implemented. So either we implement it, or we remove it from POD and doc :)
Comment 4 Katrin Fischer 2019-11-24 22:12:20 UTC
I'd vote for removing it from the documentation as a first simple step.