At least dev_install and strict_sql_modes are missing from the koha-conf.xml file. Even if there will not be used in production I feel like we should have all the possible flags available in etc/koha-conf.xml
And debian/templates/koha-conf-site.xml.in?
Agreed.
Created attachment 95045 [details] [review] Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete.
Created attachment 95048 [details] [review] Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Reads well, just wondering if this could cause problems being there by default when not using the Let's encrypt feature provided by Koha for your certs? + <tls>__DB_USE_TLS__</tls> + <ca>__DB_TLS_CA_CERTIFICATE__</ca> + <cert>__DB_TLS_CLIENT_CERTIFICATE__</cert> + <key>__DB_TLS_CLIENT_KEY__</key>
(In reply to Katrin Fischer from comment #5) > Reads well, just wondering if this could cause problems being there by > default when not using the Let's encrypt feature provided by Koha for your > certs? > > + <tls>__DB_USE_TLS__</tls> > + <ca>__DB_TLS_CA_CERTIFICATE__</ca> > + <cert>__DB_TLS_CLIENT_CERTIFICATE__</cert> > + <key>__DB_TLS_CLIENT_KEY__</key> This is stuff from an older 'feature': commit 84e48d03238ce2446e7ea24401bda0a8f4e4422d Author: Dimitris Kamenopoulos <dkamen@gmail.com> Date: Sun Dec 27 16:01:43 2015 +1300
if( $self->{'tls'} && $self->{'tls'} eq 'yes' ) { => if tls == __DB_USE_TLS_ (since it was not replaced by koha-create), the condition still works => But I could imagine that we should want to comment it
Created attachment 95184 [details] [review] Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 95185 [details] [review] Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.05
*** Bug 18245 has been marked as a duplicate of this bug. ***
*** Bug 12584 has been marked as a duplicate of this bug. ***