Jenkins is failing with: koha_1 | Error GETing http://koha:8081/cgi-bin/koha/about.pl: Internal Server Error at t/db_dependent/www/history.t line 60. koha_1 | # Looks like your test exited with 255 just after 1. koha_1 | [16:59:56] t/db_dependent/www/history.t I guess it's because the yaml file is missing from the docdir directory. From koha-testing-docker: files/templates/koha-conf-site.xml.in: <docdir>/usr/share/doc/koha-common</docdir> I suppose we need to mimick what is done for history.txt: debian/rules: # exclude history.txt from compression as about.pl needs it uncompressed debian/rules: dh_compress --exclude=history.txt debian/koha-common.docs:docs/history.txt Makefile.PL: './docs/history.txt' => { target => 'DOC_DIR', trimdir => -1 }, This may be a blocker for the release.
Tomas, do you agree? Something else I have missed?
(In reply to Jonathan Druart from comment #1) > Tomas, do you agree? Something else I have missed? 100% correct
Created attachment 89644 [details] [review] Bug 22893: Do not crash if contributors.yaml does not exist
Created attachment 89645 [details] [review] Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL)
I'd suggest 2 QA reviews and let jenkins test this patch. Unless someone wants to build a package and test the debian upgrade process.
(In reply to Jonathan Druart from comment #5) > I'd suggest 2 QA reviews and let jenkins test this patch. Unless someone > wants to build a package and test the debian upgrade process. I will build it tomorrow morning.
Ack, good catch.. can't believe I missed this during creating the original patchset.
Created attachment 89746 [details] [review] Bug 22893: Do not crash if contributors.yaml does not exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 89747 [details] [review] Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I was building packages this morning anyway so threw this into the mix. Worked for me using the procedure in 'building packages the easy way'. Signing off.
Created attachment 89761 [details] [review] Bug 22893: Do not crash if contributors.yaml does not exist Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 89762 [details] [review] Bug 22893: Embed contributors.yaml for debian packages Like history.txt we need to tell some debian/ files to copy contributors.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tested it using koha/koha-dpkg:master, everything went smooth. Good job Joubu
Awesome work all! Pushed to master for 19.05
Bug not in 18.11.x series.