DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'copyrightdate' at row 1 at /home/vagrant/kohaclone/C4/Suggestions.pm line 457
Created attachment 89763 [details] [review] Bug 22907: Add tests Do not use copyrightdate as it is weird to have it int
Created attachment 89764 [details] [review] Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try to create a new suggestion you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Test plan: Turn on strict_sql_modes, create a new suggestion, then edit it.
Created attachment 89767 [details] [review] Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try to create a new suggestion you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Test plan: Turn on strict_sql_modes, create a new suggestion, then edit it.
Created attachment 89768 [details] [review] Bug 22907: Remove previous code handling the same thing See: commit a71b96295fb07084e4f87ac1a471e89355f3c5a4 Bug 12627: Fix default values
Note that the new test will generate a DBI error, we already have one in the tests (from Patrons.t IIRC). I will try to deal with them on a separate bug report.
Created attachment 89865 [details] [review] Bug 22907: Add missing use statement
Created attachment 89872 [details] [review] Bug 22907: Add tests Do not use copyrightdate as it is weird to have it int Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89873 [details] [review] Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try to create a new suggestion you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Test plan: Turn on strict_sql_modes, create a new suggestion, then edit it. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89874 [details] [review] Bug 22907: Remove previous code handling the same thing See: commit a71b96295fb07084e4f87ac1a471e89355f3c5a4 Bug 12627: Fix default values Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89875 [details] [review] Bug 22907: Add missing use statement Signed-off-by: Liz Rea <wizzyrea@gmail.com>
QA: Looking here
I am having trouble understanding what you do here and why you do it: --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt @@ -107,14 +107,19 @@ $(document).ready(function() { var suggestionst = $("#suggestionst").dataTable($.extend(true, {}, dataTablesDefaults, { "aoColumnDefs": [ - { "aTargets": [ 0 ], "bVisible": false, "bSearchable": true }, // must be searchable for fnFilter + { "aTargets": [ 0 ], "bVisible": false, "bSearchable": false }, { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, ], "sPaginationType": "four_button" })); $("#show_only_mine").on('click', function(e){ e.preventDefault(); + //suggestionst.settings()[0].aoColumns[index].bSearchable = true; + suggestionst.setColumnSearchable(0, true); + suggestionst.rows().invalidate(); suggestionst.fnFilter('^[% loggedinuser | html %]$', 0, true); + suggestionst.setColumnSearchable(0, false); + suggestionst.rows().invalidate(); This is not about adding a new suggestion but is about adding an order from an accepted suggestion. The form newordersuggestion has some problems in current master with and without your patch. The fnFilter on borrowernumber (only mine) does not seem to work at all.. It seems unrelated to the problem you are solving on this report.
Created attachment 90168 [details] [review] Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try to create a new suggestion you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Test plan: Turn on strict_sql_modes, create a new suggestion, then edit it. Signed-off-by: Liz Rea <wizzyrea@gmail.com> JD: Edit after SO, remove unecessary changes (not related to this bug)
Created attachment 90169 [details] [review] Bug 22907: Remove previous code handling the same thing See: commit a71b96295fb07084e4f87ac1a471e89355f3c5a4 Bug 12627: Fix default values Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 90170 [details] [review] Bug 22907: Add missing use statement Signed-off-by: Liz Rea <wizzyrea@gmail.com>
(In reply to Marcel de Rooy from comment #12) > I am having trouble understanding what you do here and why you do it: [...] Oops, sorry for catching that. It was indeed related to another bug. I have amended the patch to remove those changes.
Created attachment 90177 [details] [review] Bug 22907: Add tests Do not use copyrightdate as it is weird to have it int Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 90178 [details] [review] Bug 22907: Fix new suggestion with strict sql modes With sql_strict_modes turned on, if you try to create a new suggestion you will get: Incorrect integer value: '' for column '$INT_COLUMN' at row 1 Test plan: Turn on strict_sql_modes, create a new suggestion, then edit it. Signed-off-by: Liz Rea <wizzyrea@gmail.com> JD: Edit after SO, remove unecessary changes (not related to this bug) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 90179 [details] [review] Bug 22907: Remove previous code handling the same thing See: commit a71b96295fb07084e4f87ac1a471e89355f3c5a4 Bug 12627: Fix default values Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 90180 [details] [review] Bug 22907: Add missing use statement Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06