When using the batch delete tool the show/hide columns checkboxes are misconfigured. Instead of hiding/showing the proper column the column immediately to the right is instead hidden. This effects master and 18.11.x
Created attachment 89785 [details] [review] Bug 22914: Batch Item Delete column misconfigured when using show/hide tool TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden
Created attachment 89787 [details] [review] Bug 22914: Batch Item Delete column misconfigured when using show/hide tool
attachment 89787 [details] [review] fixes a bad filter, the test plan remains the same. TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden
Created attachment 89788 [details] [review] Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 89789 [details] [review] Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22914 Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 89790 [details] [review] Bug 22914: Batch Item Delete column misconfigured when using show/hide tool
Applying: Bug 22914: Batch Item Delete column misconfigured when using show/hide tool error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt). error: could not build fake ancestor
Please provide a patch for master, Lucas.
Created attachment 89796 [details] [review] Bug 22914: Batch Item Delete column misconfigured when using show/hide tool TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden
Hi Lucas, You are doing much more that what is advertised. A new column is added (the one added by bug 19490). See also bug 8132.
The changes on 19490 caused this, the two templates share a js file, and the data passed is the same. Adding the column to the template brings things back into alignment, the data is already there, we just show it. We could leave out the whitespace changes, but I think they make it much easier to read Ultimately the item display should be an include used by both templates, but adding the column now seems a better idea than adding logic to the js to act differently in the two pages
Yes Nick, it is exactly why I let this comment. With more info I wouldn't have needed to look after them :) And also why I linked it with bug 8132. People seems to want this info (number of holds) on this page. I was asking to advertise it, like it was a new enhancement, not only a 'misalignment bug'.
Thanks Jonathan. I will be more precise with advertisement in the future. :)
Created attachment 89869 [details] [review] Bug 22914: Batch Item Delete column misconfigured when using show/hide tool Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
(In reply to Lucas Gass from comment #13) > Thanks Jonathan. I will be more precise with advertisement in the future. :) Why in the future when you can start now? :)
This is a hard one, because I really want to pass it, but I feel it's not quite right yet. :( As this is a bug report for a specific problem that also appears in 18.11, it is suited for backporting. But as it adds a new column, this is also an enhancement (with translation changes too), so it would not be backported. Also: because this only advertises the bug fix, we would not alert the libraries about the new feature in the release notes. Lucas, would you be willing to please split this into 2 separate bugs? One for the fix and one for the new feature? The heavy reindentation also makes it hard to read, having that in a first patch and the actual fix in a second patch would also make my life easier!
Hm, seeing the discussion now. I still feel this puts us in a little bit of a hard place release notes wise :)
Created attachment 90139 [details] [review] Bug 22914: Add holds column to batch item delete to fix show/hide columns behaviour The changes on 19490 caused a bug, where the show/hide column feature hides the wrong column on the items table. The two templates share a js file, and the data passed is the same. Adding the column to the template brings things back into alignment, the data is already there, we just show it. TEST PLAN: 1. Go to Tools > Batch item deletion and enter at least one barcode. 2. Try to hide a column that is showing 3. Notice it hides the wrong column 4. apply patch 5. repeat steps 1 and 2. 6. Notice the correct column is being hidden 7. Verify the new column for number of holds on the item works correctly for item and record level holds Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I decided to pass this after fixing up the bug title and commit message. Lucas, please always include a description of the problem and the most current test plan in your commit messages! Thx!
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06