Created attachment 89824 [details] [review] Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated
What is the use case for changing the date the hold was placed? (allowing them to be in the future? And should this not depend on the syspref then?)
(In reply to Katrin Fischer from comment #2) > What is the use case for changing the date the hold was placed? (allowing > them to be in the future? And should this not depend on the syspref then?) I'm not sure what the use case is if you're *not* changing a hold date to/from a future date, but I think that's good enough reason to have the ability. Tying the operation to AllowHoldDateInFuture sounds right to me.
Thanks for the feedback. I will write a followup soon.
Created attachment 89896 [details] [review] Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on
I realize that there is no aspect of the date selection process which requires specific features of the jQuery datepicker, but I think it should be used for consistency's sake.
Created attachment 89902 [details] [review] Bug 22922: Use jQuery datepicker instead of <input type="date">
Created attachment 89915 [details] [review] Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 89916 [details] [review] Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 89917 [details] [review] Bug 22922: Use jQuery datepicker instead of <input type="date"> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
This patch does a bit more than I thought - apart from changing the hold date, it also allows to change the expiration date. I think while the first should be controlled by the AllowHoldDateInFuture, the expiration date should not as it's already available to be set in the table now. Note: the expiration date has a double use, it's used to say: - Patron: I don't need this after... and also: - Library: Hold needs to picked up until ... Can you please change? I am not sure about the consequences of this change. I think the date pickers are a bit too wide in the table. Adding Owen.
(In reply to Katrin Fischer from comment #11) > I think the date > pickers are a bit too wide in the table. Adding Owen. I usually give date input fields a size attribute of 10 on the assumption that is the maximum likely number of characters in a date: 0000-00-00
We only need a syspref check and some cosmetics here... please fix!
(In reply to Katrin Fischer from comment #13) > We only need a syspref check and some cosmetics here... please fix! Which syspref and where ? attachment 89916 [details] [review] already checks AllowHoldDateInFuture
Seeing the pref check now... maybe it was only the width of the inputs missing then? (see comment#12)
Created attachment 94372 [details] [review] Bug 22922: (follow-up) Markup corrections This patch adds a "size" attribute to the datepicker input fields and adds self-closing "/".
Created attachment 94383 [details] [review] Bug 22922: Allow to modify hold dates on reserve/request.pl Test plan: 1. Place some holds 2. Go to the 'Holds' tab of the biblio record 3. Modify dates in the table and click on 'Update holds' button 4. Verify that dates have been correctly updated Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 94384 [details] [review] Bug 22922: Allow reservedate changes only if AllowHoldDateInFuture is on Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 94385 [details] [review] Bug 22922: Use jQuery datepicker instead of <input type="date"> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 94386 [details] [review] Bug 22922: (follow-up) Markup corrections This patch adds a "size" attribute to the datepicker input fields and adds self-closing "/". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This is a rather small change, so I don't want to block it any longer. Just 2 things: - There are no unit tests for the changes in Reserve.pm - I am not sure all libraries will be happy about people being able to move the pick-up date, as there is also a fine penalty in some for not picking up your holds, but for the same reason: others will like it. If you get a call that someone needs some extra time, you can do that now.
Nice work! Pushed to master for 19.11.00