With the introduction of the sys pref GDPR Policy in 18.11, having this enabled seems to affect the SCO module in Koha- if the library is also using AutoSelfCheckAllowed. If they library as the system preference AutoSelfCheckAllowed set to ALLOW, the consent of GDPR seems to get tangled up in this process. The self-check URL will get directed to /cgi-bin/koha/opac-patron-consent.pl and seem to be stuck. The consent form never appears, and this login will not be successful.
Created attachment 89881 [details] [review] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 92638 [details] [review] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92652 [details] [review] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy This patch makes Auth skip the GDPR policy check when get_template_and_user is called for sci/sco (self checkin, checkout). I do not really like the change in this form but the nature of self checkin and checkout kind of dictate it (double hack). I wanted to add a test but since that asks for mocking CGI, checkauth, etc. the time needed for that is just too much for this simple change. Test plan: Enable GDPR_Policy and self checkin/checkout. Verify that using patrons without consent is not blocking sci/sco. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Tomás Cohen Arazi from comment #3) > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Thanks Kyle and Tomas !
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.04
backported to 18.11.x for 18.11.11